Fix clickable elements with class 'btn' #4566
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes philc#3550 Update `content_scripts/link_hints.js` to make elements with class 'btn' clickable. * Add logic to `getLocalHintsForElement` to check for class 'btn' and mark elements as clickable. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/philc/vimium/issues/3550?shareId=XXXX-XXXX-XXXX-XXXX).
UncleSnail
suggested changes
Oct 29, 2024
content_scripts/link_hints.js
Outdated
Comment on lines
1216
to
1219
| if (!isClickable && className?.toLowerCase().includes("btn")) { | ||
| isClickable = true; | ||
| possibleFalsePositive = true; | ||
| } |
There was a problem hiding this comment.
This could be part of the same if statement by doing something like:
if (!isClickable && (className?.toLowerCase().includes("button") || className?.toLowerCase().includes("btn")))
There was a problem hiding this comment.
Agreed, I've made a change to address this.
…redundant check for class 'button' * Merge the if statement for 'button' and 'btn' classes * Remove redundant check for class 'button'
|
@philc I think this PR is ready for review, let me know what you think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3550
Update
content_scripts/link_hints.jsto make elements with class 'btn' clickable.getLocalHintsForElementto check for class 'btn' and mark elements as clickable.For more details, open the Copilot Workspace session.